Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if redirect_uri exists #1469

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Check if redirect_uri exists #1469

merged 1 commit into from
Jan 11, 2021

Conversation

rono23
Copy link
Contributor

@rono23 rono23 commented Jan 6, 2021

Summary

When redirect_uri is nil, it raises an error like below.

ActionView::Template::Error (undefined method `split' for nil:NilClass):

Other Information

# Remove `null: false` if you are planning to use grant flows
# that doesn't require redirect URI to be used during authorization
# like Client Credentials flow or Resource Owner Password.
t.text :redirect_uri, null: false

@doorkeeper-bot
Copy link

doorkeeper-bot commented Jan 6, 2021

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you please do what bot suggested? About changelog entry

@rono23
Copy link
Contributor Author

rono23 commented Jan 7, 2021

I updated changelog!

@nbulaj nbulaj merged commit ed19b62 into doorkeeper-gem:master Jan 11, 2021
@nbulaj
Copy link
Member

nbulaj commented Jan 11, 2021

Thanks @rono23 !

@rono23 rono23 deleted the check-redirect-uri branch January 11, 2021 08:18
@nbulaj nbulaj added this to the 5.5 milestone Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants