Use update_attribute to ensure callbacks are executed on revocation #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add changelog entry
jsdalton
force-pushed
the
fix/update-attribute-for-revocation
branch
from
6d849c7 to
37ef580
Compare
nbulaj
approved these changes
Jun 21, 2020
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts revoke method implementations to use
#update_attributeinstead of#update_column. This ensures that models mixing this functionality in will have callbacks invoked whenever the token is revoked.Some users relied on callback behavior during revocation to e.g. invalidate a cache entry when tokens are revoked. The earlier change to
#update_columnaffected this behavior and broke some use cases.Other Information