Yield application to allow_grant_flow_for_client? client credentials …

[aclemons]

…validation

Closes #1398

[nbulaj]

Something wrong with the specs.

UPD: see above comment

We had a case in the past when hooks could have Application instance or Doorkeeper::OAuth::Client, so maybe it makes sense to use this approach too

Maybe this one or somewhere else:

doorkeeper/lib/doorkeeper/oauth/authorization/token.rb

Lines 11 to 17 in 50efdb0

	oauth_client = if pre_auth_or_oauth_client.respond_to?(:application)
	pre_auth_or_oauth_client.application
	elsif pre_auth_or_oauth_client.respond_to?(:client)
	pre_auth_or_oauth_client.client
	else
	pre_auth_or_oauth_client
	end

[nbulaj]

Ah, OK, I've checked ./spec/lib/oauth/client_credentials_integration_spec.rb:11 and seems like it's incorrect.

You could just replace the let with:

let(:client) { Doorkeeper::OAuth::Client.new(FactoryBot.build_stubbed :application) }

And spec must pass

[houndci-bot]

Style/NestedParenthesizedCalls: Add parentheses to nested method call FactoryBot.build_stubbed :application.

[aclemons]

Resolved the changelog merge conflict and updated the integration spec now.

[nbulaj]

🚝

[nbulaj]

Thanks @aclemons !