Pass tests on Rails 6 and fix deprecated #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 11, 2019
|
There still some |
|
I think this PR have 2 parts so I will not squash as Danger suggest for now |
|
@nbulaj I think I've done this, you can review if you have time |
nbulaj
approved these changes
Mar 12, 2019
|
squashed, waiting CI pass |
|
Thanks @jasl ! Great work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update_attributes->update, this no harm for older RailsOther Information
This is just a initial work, although it pass tests on Rails 6, Zeitwerk breaks old extending way, I have to fix it for my app. I already committed an issue #1211
Also, Doorkeeper's build matrix is huge, and since Devise and other popular gems starting remove support of Rails 4 and Ruby 2.1 - 2.3, I suggest Doorkeeper follow them, we can discuss at #1212