Refactor StaleRecordsCleaner to be ORM agnostic #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 4, 2018
nbulaj
force-pushed
the
refactor_stale_records_cleaner
branch
from
f6b65b4 to
0441c87
Compare
houndci-bot
reviewed
Oct 4, 2018
nbulaj
force-pushed
the
refactor_stale_records_cleaner
branch
2 times, most recently
from
5735b84 to
a8db8fa
Compare
nbulaj
force-pushed
the
refactor_stale_records_cleaner
branch
from
4c53038 to
a67568d
Compare
nbulaj
force-pushed
the
refactor_stale_records_cleaner
branch
from
d5144b7 to
614ec7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
StaleRecordsCleanerto be ORM agnositc so every ORM extension could write it's own.