Better format callback URLs on index page #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rmm5t . Could you please provide some screens over how it was look before and after? Currently I have no chance to see it myself, sorry. Also could you please add a changelog entry to NEWS.md and then squash commits to a single one? Something like "[#pr number] Simple formating of callback URLs". Also maybe it is required to do the same for detailed page (SHOW action) ? |
|
Hi @nbulaj. Sure thing. All done. I added the screenshots to the description of this PR above, and I added a line to the NEWS. Thanks! |
|
Thanks @rmm5t for this changes! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a visual improvement to show each callback URL on it's own line per application
Before
After