#1097: make admin controller forbidden by default #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 13, 2018
| default: ->(_routes) {} | ||
| default: (lambda do |_routes| | ||
| ::Rails.logger.warn( | ||
| I18n.t('doorkeeper.errors.messages.admin_authenticator_not_configured') |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [86/80]
admin_authenticator is not configured by developers.
nbulaj
force-pushed
the
admin_authenticator_default
branch
from
d8d98bd to
07afb4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict access to admin controller with head 403 if admin_authenticator is not configured by developers.