Added :after_successful_authorization callback #1064

nattfodd · 2018-03-26T13:21:30Z

Summary

This PR adds an ability to run some code after successful authorization. TLDR: #1062

Example:

Doorkeeper.configure do
  after_successful_authorization do |controller|
    controller.session[:logout_urls] << 
      Doorkeeper::Application
      .find_by(controller.request.params.slice(:redirect_uri))
      .logout_uri
  end
end

houndci-bot · 2018-03-26T13:28:14Z

spec/controllers/authorizations_controller_spec.rb

+    it 'should call :after_successful_authorization callback' do
+      expect(Doorkeeper.configuration)
+        .to receive_message_chain(:after_successful_authorization, :call)
+        .with(instance_of(described_class))


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T13:28:14Z

spec/controllers/authorizations_controller_spec.rb

+
+    it 'should call :after_successful_authorization callback' do
+      expect(Doorkeeper.configuration)
+        .to receive_message_chain(:after_successful_authorization, :call)


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T13:28:14Z

spec/controllers/authorizations_controller_spec.rb

+    after do
+      allow(Doorkeeper.configuration)
+        .to receive(:skip_authorization)
+        .and_return(proc { true })


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T13:28:15Z

spec/controllers/authorizations_controller_spec.rb

+  describe 'GET #new with callbacks' do
+    after do
+      allow(Doorkeeper.configuration)
+        .to receive(:skip_authorization)


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T13:28:15Z

spec/controllers/authorizations_controller_spec.rb

+    it 'should call :after_successful_authorization callback' do
+      expect(Doorkeeper.configuration)
+        .to receive_message_chain(:after_successful_authorization, :call)
+        .with(instance_of(described_class))


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T13:28:15Z

spec/controllers/authorizations_controller_spec.rb

+
+    it 'should call :after_successful_authorization callback' do
+      expect(Doorkeeper.configuration)
+        .to receive_message_chain(:after_successful_authorization, :call)


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T13:28:15Z

spec/controllers/authorizations_controller_spec.rb

+    after do
+      allow(Doorkeeper.configuration)
+        .to receive(:skip_authorization)
+        .and_return(proc { true })


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T13:28:15Z

spec/controllers/authorizations_controller_spec.rb

+  describe 'GET #new with callbacks' do
+    after do
+      allow(Doorkeeper.configuration)
+        .to receive(:skip_authorization)


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-03-26T14:09:36Z

lib/doorkeeper/config.rb

@@ -217,6 +217,7 @@ def option(name, options = {})
             ::Rails.logger.warn(I18n.t('doorkeeper.errors.messages.credential_flow_not_configured'))
             nil
           end)
+    option :after_successful_authorization,  default: ->(_controller) {}


Unnecessary spacing detected.

nbulaj · 2018-03-27T07:14:47Z

app/controllers/doorkeeper/authorizations_controller.rb

@@ -24,6 +24,7 @@ def destroy
    def render_success


Can we add before hook? I think it can be useful for some purposes, moreover it will comply with other Doorkeeper hooks

nbulaj · 2018-03-27T07:21:28Z

lib/doorkeeper/config.rb

@@ -217,6 +217,7 @@ def option(name, options = {})
             ::Rails.logger.warn(I18n.t('doorkeeper.errors.messages.credential_flow_not_configured'))
             nil
           end)
+    option :after_successful_authorization, default: ->(_controller) {}


Let's rename _controller to _context

nbulaj · 2018-03-27T07:22:11Z

Just small fixes for comments above and it would be great 👍

Also after finishing the work - could you please add a changelog entry to NEWS.md and squash all commits to a single one? Thanks

They expose AuthorizationController context in the :new method Use cases: for example, when you need to set some cookies after successful authorization

nattfodd · 2018-03-27T08:05:07Z

@nbulaj it's all done, thank you for your points :)

nbulaj · 2018-03-28T21:47:40Z

Thank you for your work!

houndci-bot reviewed Mar 26, 2018

View reviewed changes

nattfodd force-pushed the after_successful_authorization branch 3 times, most recently from a16de71 to 1885305 Compare March 26, 2018 14:09

houndci-bot reviewed Mar 26, 2018

View reviewed changes

nattfodd force-pushed the after_successful_authorization branch from 1885305 to 2b5e3d1 Compare March 26, 2018 14:11

nattfodd mentioned this pull request Mar 27, 2018

Hooks around AuthorizationController / Single Sign Out feature #1062

Closed

nbulaj reviewed Mar 27, 2018

View reviewed changes

nattfodd force-pushed the after_successful_authorization branch from 3f36e1f to 42126a7 Compare March 27, 2018 07:49

Added before/after_successful_authorization callbacks

842f450

They expose AuthorizationController context in the :new method Use cases: for example, when you need to set some cookies after successful authorization

nattfodd force-pushed the after_successful_authorization branch from 42126a7 to 842f450 Compare March 27, 2018 07:50

nbulaj merged commit 37f4e51 into doorkeeper-gem:master Mar 28, 2018

nbulaj added this to the 5.0 milestone Mar 29, 2018

nbulaj added the enhancement label Mar 29, 2018

nbulaj added a commit that referenced this pull request Mar 31, 2018

Add options from #1064 to initializer template

ed95d94

mdeutsch mentioned this pull request Apr 6, 2018

Call before/after_successful_authorization callbacks on create as well as new #1075

Merged

felipeelias mentioned this pull request Apr 15, 2019

Undefined method logout_uri #1244

Closed

fotos mentioned this pull request May 31, 2019

Add #{before,after}_successful_authorization hooks in Doorkeeper::TokensController #1264

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added :after_successful_authorization callback #1064

Added :after_successful_authorization callback #1064

nattfodd commented Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

houndci-bot Mar 26, 2018

nbulaj Mar 27, 2018

nbulaj Mar 27, 2018

nbulaj commented Mar 27, 2018 •

edited

Loading

nattfodd commented Mar 27, 2018

nbulaj commented Mar 28, 2018

Added :after_successful_authorization callback #1064

Added :after_successful_authorization callback #1064

Conversation

nattfodd commented Mar 26, 2018

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nbulaj commented Mar 27, 2018 • edited Loading

nattfodd commented Mar 27, 2018

nbulaj commented Mar 28, 2018

nbulaj commented Mar 27, 2018 •

edited

Loading