Allow Application#redirect_uri= to handle array of URIs #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @f3ndot . That is great and I completely agree about renaming it to |
|
I agree.
We could keep the underlying column redirect_uri as is but write the
accessor methods as redirect_uris.
The existing redirect_uri accessors can remain but emit a deprecation
warning and the next major release will rename the column.
On Thu, Feb 15, 2018, 4:41 AM Nikita Bulai ***@***.***> wrote:
Hi @f3ndot <https://github.com/f3ndot> . That is great and I completely
agree about renaming it to :redirect_uris in future Doorkeeper version,
but we need to worry about legacy projects that will need to rename it with
responsible migration.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1035 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtLwc3evL-JAKWu97eMrnk9hnyGYo3iks5tU_vOgaJpZM4SFfJj>
.
--
Justin Bull
PGP Fingerprint: E09D 38DE 8FB7 5745 2044 A0F4 1A2B DEAA 68FD B34C
|
|
Agree. Also we must write upgrading guides for new major release and mention this feature. Can you please resolve the conflicts and squash commits? Also could you please add a changelog entry to the NEWS.md ? |
Add entry to NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little convenience to make the code more intuitive.
I think for the 5.0 milestone we should consider renaming the attribute to
Application#redirect_urisand have it return an array of strings.