Fix #1044: move #ordered_by method to concern

Remove BaseRecord for AR models and move #ordered_by method to concerns
so anyone who patches default models can reopen them.

lib/doorkeeper/models/concerns/orderable.rb

@@ -0,0 +1,13 @@
+module Doorkeeper
+  module Models
+    module Orderable
+      extend ActiveSupport::Concern
+
+      module ClassMethods
+        def ordered_by(attribute, direction = :asc)
+          order(attribute => direction)
+        end
+      end
+    end
+  end
+end

lib/doorkeeper/orm/active_record.rb

@@ -5,7 +5,7 @@ module Orm
     module ActiveRecord
       def self.initialize_models!
         lazy_load do
-          require 'doorkeeper/orm/active_record/base_record'
+          require 'doorkeeper/models/concerns/orderable'
           require 'doorkeeper/orm/active_record/access_grant'
           require 'doorkeeper/orm/active_record/access_token'
           require 'doorkeeper/orm/active_record/application'

lib/doorkeeper/orm/active_record/access_grant.rb

@@ -1,7 +1,8 @@
 module Doorkeeper
-  class AccessGrant < BaseRecord
+  class AccessGrant < ActiveRecord::Base
     self.table_name = "#{table_name_prefix}oauth_access_grants#{table_name_suffix}".to_sym
 
+    include Models::Orderable
     include AccessGrantMixin
     include ActiveModel::MassAssignmentSecurity if defined?(::ProtectedAttributes)
 

lib/doorkeeper/orm/active_record/access_token.rb

@@ -1,7 +1,8 @@
 module Doorkeeper
-  class AccessToken < BaseRecord
+  class AccessToken < ActiveRecord::Base
     self.table_name = "#{table_name_prefix}oauth_access_tokens#{table_name_suffix}".to_sym
 
+    include Models::Orderable
     include AccessTokenMixin
     include ActiveModel::MassAssignmentSecurity if defined?(::ProtectedAttributes)
 

lib/doorkeeper/orm/active_record/application.rb

@@ -1,7 +1,8 @@
 module Doorkeeper
-  class Application < BaseRecord
+  class Application < ActiveRecord::Base
     self.table_name = "#{table_name_prefix}oauth_applications#{table_name_suffix}".to_sym
 
+    include Models::Orderable
     include ApplicationMixin
     include ActiveModel::MassAssignmentSecurity if defined?(::ProtectedAttributes)
 

lib/doorkeeper/version.rb

@@ -7,7 +7,7 @@ module VERSION
     # Semantic versioning
     MAJOR = 4
     MINOR = 3
-    TINY = 0
+    TINY = 1
 
     # Full version number
     STRING = [MAJOR, MINOR, TINY].compact.join('.')