Have strategy requests all invoke BaseRequest's callbacks (#1001)

* Have BaseRequest subclasses invoke super on callbacks

This makes the BaseRequest#before_successful_response and BaseRequest#after_successful_response generally available. Some subclasses implement these callbacks, which then requires explicit per-strategy hooking vs one global one on BaseRequest, if desired by the developer.

* [Lint] Prefer double quotes for #it

lib/doorkeeper/oauth/authorization_code_request.rb

@@ -28,6 +28,7 @@ def before_successful_response
                                       grant.scopes,
                                       server)
         end
+        super
       end
 
       def validate_attributes

lib/doorkeeper/oauth/password_access_token_request.rb

@@ -22,6 +22,7 @@ def initialize(server, client, resource_owner, parameters = {})
 
       def before_successful_response
         find_or_create_access_token(client, resource_owner.id, scopes, server)
+        super
       end
 
       def validate_scopes

lib/doorkeeper/oauth/refresh_token_request.rb

@@ -35,6 +35,7 @@ def before_successful_response
           refresh_token.revoke unless refresh_token_revoked_on_use?
           create_access_token
         end
+        super
       end
 
       def refresh_token_revoked_on_use?

spec/lib/oauth/authorization_code_request_spec.rb

@@ -80,6 +80,12 @@ module Doorkeeper::OAuth
       end.to_not change { Doorkeeper::AccessToken.count }
     end
 
+    it "calls BaseRequest callback methods" do
+      expect_any_instance_of(BaseRequest).to receive(:before_successful_response).once
+      expect_any_instance_of(BaseRequest).to receive(:after_successful_response).once
+      subject.authorize
+    end
+
     context "when redirect_uri contains some query params" do
       let(:redirect_uri) { client.redirect_uri + "?query=q" }
 

spec/lib/oauth/password_access_token_request_spec.rb

@@ -67,6 +67,12 @@ module Doorkeeper::OAuth
       end.to_not change { Doorkeeper::AccessToken.count }
     end
 
+    it "calls BaseRequest callback methods" do
+      expect_any_instance_of(BaseRequest).to receive(:before_successful_response).once
+      expect_any_instance_of(BaseRequest).to receive(:after_successful_response).once
+      subject.authorize
+    end
+
     describe 'with scopes' do
       subject do
         PasswordAccessTokenRequest.new(server, client, owner, scope: 'public')

spec/lib/oauth/refresh_token_request_spec.rb

@@ -44,6 +44,12 @@ module Doorkeeper::OAuth
       expect { subject.authorize }.to change { refresh_token.revoked? }.from(false).to(true)
     end
 
+    it "calls BaseRequest callback methods" do
+      expect_any_instance_of(BaseRequest).to receive(:before_successful_response).once
+      expect_any_instance_of(BaseRequest).to receive(:after_successful_response).once
+      subject.authorize
+    end
+
     it 'requires the refresh token' do
       subject.refresh_token = nil
       subject.validate