Fixes #6 Migrate RawKeyboardEvent and related implications according … #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to Flutter recommendations described here: flutter/flutter#136419
I swapped out the Raw version for the recommended Hardware version, and updated
onKey
toonKeyEvent
in our keyboard listeners'FocusNode
s as instructed by the migration guide: https://docs.flutter.dev/release/breaking-changes/key-event-migration . I believe merging this PR will get everyone on Flutter 3.19 compiling again without breaking existing functionality, but welcome further examination and manual testing.I believe this change has caused 3 tests to fail in the
pluto_key_manager_event_test.dart
file, and have included a comment there to reflect what I believe to be the cause and best course of action for now. I have tested the 3 failing test cases manually (irl with a bluetooth keyboard on macOS and Chrome) and everything behaves as expected. I will paste the comment here as well:Additionally, I have reached out on the relevant Flutter issue (first link in this comment) to provide more clarity on if this test is failing due to an incomplete Flutter migration.