Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Make link clickable/openable #108

Closed
sathishmanohar opened this issue Mar 20, 2023 · 5 comments
Closed

[FEAT] Make link clickable/openable #108

sathishmanohar opened this issue Mar 20, 2023 · 5 comments
Assignees
Labels
completed Issues that are fixed and will be out in the next release enhancement New feature or request

Comments

@sathishmanohar
Copy link
Contributor

I have a link in a description. When I click on the link I expect the link to open in my default browser but as of now nothing is happening.

The link is detected and underlined. The cursor changes to link click cursor but on click nothing happens.

@sathishmanohar sathishmanohar added the bug Something isn't working label Mar 20, 2023
@kraanzu
Copy link
Member

kraanzu commented Mar 20, 2023

Hmmm... Didn't add the feature but can do

@kraanzu kraanzu added enhancement New feature or request and removed bug Something isn't working labels Mar 20, 2023
@kraanzu kraanzu changed the title [BUG] Link clicks doesn't do anything [FEAT] Make link clickable/openable Mar 20, 2023
@Justinzobel
Copy link

Sounds more like an issue with the terminal. I use Konsole by KDE and I have the option to click links when holding CTRL.

@sathishmanohar
Copy link
Contributor Author

I confirm ctrl+click works on a few terminals and it doesn't work on kitty. Is there a way to make the behavior more uniform/predictable across terminals.

@kraanzu
Copy link
Member

kraanzu commented May 23, 2023

Is there a way to make the behavior more uniform/predictable across terminals.

Yes If I can use a proper regex to determine URLs then I make it clickable I suppose :D

@kyeboard
Copy link
Collaborator

kyeboard commented May 23, 2023

I confirm ctrl+click works on a few terminals and it doesn't work on kitty. Is there a way to make the behavior more uniform/predictable across terminals.

Try just clicking it instead of pressing ctrl. I just tested on my pc and urls open if i just click.... however it doesnt if i alongside press ctrl

Edit: Turns out you need to add https:// or http:// as a prefix to your url, otherwise it doesnt open.

@kyeboard kyeboard self-assigned this Aug 13, 2023
@kraanzu kraanzu added the completed Issues that are fixed and will be out in the next release label Aug 18, 2023
kraanzu added a commit that referenced this issue Aug 20, 2023
@kraanzu kraanzu closed this as completed in 6038829 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed Issues that are fixed and will be out in the next release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants