Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default settings to prevent ssgi feedback loop #844

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: change default settings to prevent ssgi feedback loop #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package/Shaders/AmbientCompositeCS.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ void SampleSSGI(uint2 pixCoord, float3 normalWS, out half ao, out half3 il)
linDiffuseColor *= ssgiAo;
# endif

ssgiIl *= linAlbedo;
DiffuseAmbientRW[dispatchID.xy] = linAlbedo * linDirectionalAmbientColor + ssgiIl;
linDiffuseColor += ssgiIl;
float clampedLinAlbedo = min(linAlbedo, 0.9);
DiffuseAmbientRW[dispatchID.xy] = clampedLinAlbedo * (linDirectionalAmbientColor + ssgiIl);
linDiffuseColor += ssgiIl * linAlbedo;
#endif

linAmbient *= visibility;
Expand Down
2 changes: 1 addition & 1 deletion src/Features/ScreenSpaceGI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ struct ScreenSpaceGI : Feature
// gi
float BackfaceStrength = 0.f;
bool EnableGIBounce = true;
float GIBounceFade = 1.f;
float GIBounceFade = .5f;
float GIDistanceCompensation = 0.f;
// mix
float AOPower = 2.f;
Expand Down
Loading