-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update build workflow to include assets #84
Conversation
Thanks for doing this. I'm not sure it is a good idea to do it on all fork pushes. The build itself can eat a lot of ci time and I definitely push a lot just to sync. Is it possible to trigger it on PRs to the main repo based on some tag a user can add? Or if it starts with feat:? Or maybe it can be simpler and be a workflow trigger and we just manually ask someone to trigger and post a release as part of our PR process. Thinking more, having that may let us build nightlies or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still want this, but can you let me know if we can address some of my thoughts? Even if it's just saying it's not feasible or already did it?
Thanks!
I'll think some more about this flow! Maybe the easiest it to have it manually triggerable like you mentioned... |
b41fe7b
to
7ffc2a5
Compare
7ffc2a5
to
a4b67f3
Compare
Simplified this PR to update the existing build pipeline instead (Updated main description)! Now also bundles all the addons on the release as well, that then can be triggered by the creator of a PR. I think this is a good starting point that can be extended in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Added a workflow that build and creates a release on the fork repo, will run on every fork push. Not on doodlom repo.Update the build workflow to also bundle in addons, can be manually triggered like before on forks to easier test new PRs
Example release for this PR:
https://github.com/FlayaN/skyrim-community-shaders/releases/tag/untagged-59d9606a360720ff5014
Uploads all the zip files (the output from CMAKE option
ZIP_TO_DIST
)Creates a combined zip with all the files in one package (Same files that are copied to output when usingAUTO_PLUGIN_DEPLOYMENT
)This allows to easier test a PR before approving it, can also make "alpha/beta" releases easier for posting them on discord in #forums