Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user specific configs #67

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Conversation

alandtse
Copy link
Collaborator

User configs will be saved in CommunityShadersUSER.json. This will be loaded first and then fallback to CommunityShaders.json.

We should probably add logic that will invalidate a config if its version is too old using the Version key.

closes #66

@alandtse
Copy link
Collaborator Author

Actually, I think forcing a save may be enough to populate all the necessary values on version change.

@doodlum
Copy link
Owner

doodlum commented Aug 31, 2023

I think this only makes sense if it contains changed values. Otherwise users will be unsure what they changed, and we probably need code to retroactively update configs where we have changed the default value.

@alandtse
Copy link
Collaborator Author

Code as written will try to read the existing config. If it can, it will then check version and then save the new format. So it should have the same effect.

@doodlum doodlum merged commit 14edc43 into doodlum:dev Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants