Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: introduces a windows based build container #524

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

mnkll
Copy link
Contributor

@mnkll mnkll commented Sep 12, 2024

For those preferring to build in containers, based on a windows container. Might do Linux in the future to avoid the cursed windows containers and their size, even when taking core images. This could be the first step towards some form of CI setup.. or stay just another, quicker way to build.

Not perfect, had ideas to reuse the BuildRelease.bat more by putting the user preset check and generation plus directory replacement in there.
Or extend it with another parameter and pass the output directory overwrite required for the container directly to cmake (maybe -DCommunityShadersOutputDir=C:\skyrim-community-shaders).
CMD limitations make that ugly without extra dependency so it stays in the container specific script for now.

Any suggestions welcome.

@mnkll mnkll marked this pull request as draft September 12, 2024 22:50
@mnkll mnkll marked this pull request as ready for review September 12, 2024 23:34
@alandtse
Copy link
Collaborator

alandtse commented Sep 13, 2024

Looks like a build: PR. CI: typically covers actually ci for the project. That said, look like a good idea. We do probably want a ci that confirms PRs build and probably a release ci.

Please also review and approve #513 before we merge this.

@mnkll mnkll changed the title ci: introduces a windows based build container build: introduces a windows based build container Sep 13, 2024
@mnkll
Copy link
Contributor Author

mnkll commented Sep 13, 2024

Looks like a build: PR. CI: typically covers actually ci for the project. That said, look like a good idea. We do probably want a ci that confirms PRs build and probably a release ci.

Please also review and approve #513 before we merge this.

Don't have the status to review that I think, OK with me tho.

@alandtse
Copy link
Collaborator

Anyone should be able to hit approve. If you can't, just comment saying you approve there.

@doodlum doodlum merged commit e03f1c9 into doodlum:dev Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants