Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix ctd due to NiParticles offset #48

Merged
merged 8 commits into from
Aug 23, 2023
Merged

fix: fix ctd due to NiParticles offset #48

merged 8 commits into from
Aug 23, 2023

Conversation

alandtse
Copy link
Collaborator

Note the need to bump dependencies due to the updates to commonlibng.

@alandtse alandtse marked this pull request as draft August 22, 2023 19:48
@alandtse alandtse requested a review from doodlum August 23, 2023 05:34
@alandtse alandtse marked this pull request as ready for review August 23, 2023 05:34
@alandtse
fix: bad colors for VR enblights
ba4f2d1 
TriShape had bad offsets and had a 0 vertex count.
@alandtse
refactor: remove unnecessary cast
55fdba7 
RE showed the material was already BSEffectShaderMaterial*
@alandtse
Merge branch 'new_llf' of https://github.com/alandtse/skyrim-communit…
757b20a 
…y-shaders into new_llf
doodlum
doodlum approved these changes Aug 23, 2023
View reviewed changes
Copy link
Owner

@doodlum doodlum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. I think it should have been noted that this included formatting and cleanup as well.

@doodlum doodlum merged commit d24fe3c into doodlum:dev Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlum doodlum doodlum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alandtse @doodlum