Refactor hlsl #26
Merged
Refactor hlsl #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, started seeing errors when working on lighting: EDIT: False alarm on my side. Pasted a bad file into my VR.hlsl. Looks fine. |
Simplify Flat and VR code with helper functions. NG_mul has been added to replace mul when accessing FrameBuffer content. Additionally code from ShadowPS.hlsl was moved to Framebuffer.hlsl.
|
Not sure why the git checkout is failing; but regardless, it's manually linted on my side. |
NG_mul is no longer necessary now that it's clear eyeIndex is just an array selector. This means that flat will have to define eyeIndex for full VR compatibility. This simplifies the code significantly throughout.
The VR code used a different set of disassembly which made it appear the divisor had to be different. This now uses the correct w component
This is playable but certain terrain edges may have bugs. I suspect its snow shader related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in VR and 1.5.97. @doodlum, please do a sanity check before merging it in though. There should be no functional change as it's code simplification.
Please see the new
NG_mulwhich should replacemulwhen multiplying against a 4x4 matrix from FrameBuffer.hlsl. It probably can be used on PerGeometry too. Check out the reduction inRunGrass.hlsl.