Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VR and Flat grass lighting #23

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix VR and Flat grass lighting #23

merged 3 commits into from
Jul 12, 2023

Conversation

alandtse
Copy link
Collaborator

Tested in VR and 1.5.97.

Here's what fixed it:

  • I inadvertently clobbered PerFrame later in the shader code so that's why the cb was broken. Renamed the conflict so the shader should work.
  • There was also a random bug in grasslighting. I'm not sure why the helper function messed things up but undoing it seems to have resolved the lighting issue.

Lastly, I also undid your inadvertent update of package/Shaders/RunGrass.hlsl.

@doodlum doodlum merged commit c78e551 into doodlum:vrfixes Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alandtse @doodlum