Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revised dynamic cubemaps #218

Merged
merged 9 commits into from
Mar 15, 2024
Merged

feat: revised dynamic cubemaps #218

merged 9 commits into from
Mar 15, 2024

Conversation

doodlum
Copy link
Owner

@doodlum doodlum commented Mar 14, 2024

also a fix for the LLF

@@ -32,6 +33,73 @@ void DynamicCubemaps::DrawSettings()
ImGui::EndTable();
}
}

if (ImGui::TreeNodeEx("Dynamic Cubemap Creator", ImGuiTreeNodeFlags_DefaultOpen)) {
ImGui::Text("You must enable creator mode by adding the shader define CREATOR");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we should auto do this for them or just not enable this menu unless that's set.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but this is no different to the current LLF light visualisation settings. we should review it at a later date.

Copy link
Collaborator

@alandtse alandtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any obvious bugs in VR. Did not try creator mode though.

@doodlum doodlum merged commit 5d580a8 into dev Mar 15, 2024
@doodlum doodlum deleted the dynamic-cubemaps-revision branch March 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants