Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feature-level restore defaults option #158

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat: add feature-level restore defaults option #158

merged 1 commit into from
Jan 30, 2024

Conversation

TheRiverwoodModder
Copy link
Contributor

Added option to restore defaults at the feature level for all features except dynamic cubemaps.

  • Implemented virtual function on the Feature base class and then implemented it on all of the features.
  • Added a button to all feature settings menus to restore defaults - except for dynamic cubemaps
  • Tested with a debugger attached to make sure that ImGui behaved

@doodlum
Copy link
Owner

doodlum commented Jan 24, 2024 •
edited
Loading

Looks good, I think it just duplicate code removed where possible, maybe a helper function? Or could be added to Feature itself

@alandtse
Copy link
Collaborator

We'll spawn an issue to cover the refactoring.

@alandtse alandtse mentioned this pull request Jan 30, 2024
Closed
@alandtse alandtse changed the title feat: feature-level restore defaults option feat: add feature-level restore defaults option Jan 30, 2024
@alandtse alandtse merged commit b7be5b9 into doodlum:dev Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRiverwoodModder @doodlum @alandtse