-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix wetness calculation logic #151
Conversation
…ness to the CPU, and Fixed perPass struct
Version = 0-9-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're doing semantic versioning, this should be 0.10.0 since it's a new feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIll use semantic versioning in future updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test the effect, but if @doodlum is good with it I just have minor comments.
To do fog, please do something along the lines of:
Otherwise it's going to be too unreliable. You don't need to extract any information from the weather itself, it's already available in Sky. We only needed to use the weathers to get that particle information, afaik. |
What's the main benefit of the refactor? Performance, fix, feature, maintainability? Not a big deal but just trying to find a better description than chore/refactor which are not version incrementing. |
In that case, "Fix" is probably the best prefix. It fixed several issues and improved the weather transition curve. |
Added Fog wetnessand made Snow & Rain detection more robustAdded settings for Fog & Snow Max Wetnessto allow for unique values for rain fog, and snow max wetnessEdit: Removed snow and fog calculation from this PR. Will reintroduce in a later build.