-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Consolidate multiline strings in feature code #143
Conversation
DistantTreeLighting: * Complex Tree LOD Tooltip * Subsurface Scattering tooltip ExtendedMaterials: * Complex Material Checkbox tooltip * Enable Parallax tooltip * High Quality checkbox tooltip * Blend Range slider tooltip * Enable Shadows checkbox tooltip GrassLighting: * Subsurface Scattering (SSS) Amount slider tooltip LightLimitFix: * Lights Visualization Mode combo box tooltip
Thanks. I think the newlines can be removed but @doodlum, what do you think? |
Build available at https://github.com/rjwignar/skyrim-community-shaders/releases/tag/menuMultilines for testing. |
I believe that the new lines were included to make the text easier to read/digestible. But we did also have issues with text wrapping previously. |
Ok, let's drop the newlines. |
* ExtendedMaterials.cpp * GrassLighting.cpp * LightLimitFix.cpp
I've updated the PR, with the commented-out original tooltips (that used newlines) removed. |
Summary of Changes
Following our discussion in #119 (comment), I searched for and handled consecutive
ImGui::Text()
calls in the feature code(in the src folder).
I used git grep to find module files that have
ImGui::Text()
calls and consolidated tooltips that use consecutiveImGui::Text()
calls.I modified tooltips in the following modules:
DistantTreeLighting
:ExtendedMaterials
:GrassLighting
:LightLimitFix
:I noticed all tooltips above originally contained newline characters,
\n
.I removed them in my changes, but I commented out the original tooltips for reference in case I need to preserve the newline characters.
If the newlines don't need to be preserved, I can remove the commented-out code and update the PR.
Thank you for considering these changes.