feat: static branching instead of macros #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
doodlum
commented
Sep 24, 2023
•
doodlum
commented
- Only touches Lighting.hlsl and Water.hlsl because only those have a permutation problem right now.
- Could reduce techniques further by checking for the improved snow shader, and modifying techniques as well as flags (50% smaller or more, with those changes on Lighting.hlsl)
- Need to review performance changes. So far seems to be negligible ( < 0.05 ms )
chore: sync with dev
4 tasks
alandtse
approved these changes
Sep 25, 2023
alandtse
added a commit
to alandtse/skyrim-community-shaders
that referenced
this pull request
Sep 25, 2023
Fixes issue from doodlum#109
alandtse
added a commit
to TheRiverwoodModder/skyrim-community-shaders
that referenced
this pull request
Sep 25, 2023
Fixes issue from doodlum#109
doodlum
pushed a commit
that referenced
this pull request
Sep 25, 2023
* Early shader work on Rain Wetness Effects * Added some comments * Added the main files. Still need to figure out the last step and work through some bugs. * Got the effect working end-to-end. * No more conflict with LLF. Adding it to feature list for both VR and flat. * Added fade-in / fade-out transitions for the rain effect to only get wet once it has been raining and take some time to dry after it is done raining * Added tooltips to the feature menu * style: 🎨 apply clang-format changes * - IsRaining and IsOutdoors should no longer exist. Only using EnableEffect in the shader. - Moved EnableRainWetnessEffects setting check to the CPU and it skips calculating anything when it is disabled. - Moved the transition easing function to the CPU. * style: 🎨 apply clang-format changes * Bug fixes - Fixed bug in lighting.hlsl where Snow was having the effect applied to it and glowing during rain. - String change in a tooltip * style: 🎨 apply clang-format changes * Updated defaults for specular and diffuse multipliers to have a stronger wetness effect. * Adding back in the snow fix that got undone in the merge. * Added separate settings for effect at night vs during the day * style: 🎨 apply clang-format changes * Moved multiplier calculations to the CPU - Also made min value for Shininess multiplier 0.5 * style: 🎨 apply clang-format changes * Added a safeguard to prevent certain weathers from returning negative transition values. - Updated nighttime defaults * style: 🎨 apply clang-format changes * Bug fix - Finished transition fix for negative precipitationBeginFadeIn values * style: 🎨 apply clang-format changes * fix: fix compilation error in treelod Fixes issue from #109 --------- Co-authored-by: TheRiverwoodModder <[email protected]> Co-authored-by: Alan Tse <[email protected]> Co-authored-by: alandtse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.