Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Putting shared resources in a common hlsl header #171

Closed
Pentalimbed opened this issue Feb 1, 2024 · 1 comment · Fixed by #174
Closed

Putting shared resources in a common hlsl header #171

Pentalimbed opened this issue Feb 1, 2024 · 1 comment · Fixed by #174

Comments

@Pentalimbed
Copy link
Collaborator

For example,

struct LightingData
{
	float WaterHeight[25];
	bool Reflections;
};

StructuredBuffer<LightingData> lightingData : register(t126);

should be included in a new hlsl in Common/ folder
@alandtse
Copy link
Collaborator

alandtse commented Feb 1, 2024

See also #172 (comment)

@FlayaN FlayaN mentioned this issue Feb 7, 2024
Merged
FlayaN added a commit to FlayaN/skyrim-community-shaders that referenced this issue Feb 7, 2024
@FlayaN
refactor: move LightingData into common
d910e7f 
fix doodlum#171
doodlum pushed a commit that referenced this issue Feb 8, 2024
@FlayaN
refactor: move LightingData into common (#174)
f622afe 
* refactor: move LightingData into common
fix #171

* style: 🎨 apply clang-format changes

* style: add endline

---------

Co-authored-by: FlayaN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move LightingData into common FlayaN/skyrim-community-shaders
2 participants
@alandtse @Pentalimbed