Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC-4063 Reworked React Example RTUUI components #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

EPIC-4063 Reworked React Example RTUUI components #90

wants to merge 3 commits into from

Conversation

ben-scanbot
Copy link
Contributor

No description provided.

@ben-scanbot
react-js Removed redundant code from App.tsx
96d6706 
EPIC-4063
@ben-scanbot
react-js Refactoring
5a2da41 
Moved the logic that makes sure that the DOM element to which we bind the websdk-scanner stays the same during rerendering from App.tsx to BaseScannerComponent.
This makes the scanner components easier to use.
EPIC-4063
@ben-scanbot ben-scanbot requested a review from Nikituh December 29, 2023 16:32
Nikituh
Nikituh reviewed Jan 5, 2024
View reviewed changes
react-js/src/App.tsx Outdated Show resolved Hide resolved
Nikituh
Nikituh approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@Nikituh Nikituh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, simplified it at a lot. Ideally I'd like to see App.tsx even smaller, but it should probably be done as a different task, somewhere down the line

@ben-scanbot
Formatting
e6e5eda 
EPIC-4063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikituh Nikituh Nikituh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-scanbot @Nikituh