refactor(GraphEdge): Disable events on GraphEdge #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
force-pushed
the
refactor/disable-graphedge-events
branch
from
36198bd to
a284e1b
Compare
donmccurdy
force-pushed
the
refactor/disable-graphedge-events
branch
from
a284e1b to
839f0ff
Compare
donmccurdy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the GraphEdge class extends EventDispatcher, and emits 'dispose' events. These events are used (internally, only) to maintain references between GraphNodes. If an edge is disposed, the parent GraphNode is listening for that event and will remove its own reference to the GraphEdge.
In large graphs (1M+ nodes) these listeners require non-trivial memory allocation, and bulk disposal is slower than necessary because the process relies heavily on event callbacks.
Because the events have always been for 'internal' use, I believe it should be safe to remove events on the GraphEdge class, and to implement the required reference maintenance without them.
The change will be published as a v2 → v3 update.