Test automation

.github/workflows/component.yml

@@ -93,7 +93,7 @@ jobs:
         run: docker-compose run -d -p 8983:8983 solr
       - name: Run Backend Tests
         run: |
-          ./gradlew createConfigs componentTests
+          ./gradlew createConfigs componentTests --continue
           ./gradlew jacocoReport
       - name: Generate Types
         run: ./gradlew generateTypes

.github/workflows/jdk17.yml

@@ -31,4 +31,4 @@ jobs:
       - name: Run Solr search service
         run: docker-compose run -d -p 8983:8983 solr
       - name: Run Backend Tests
-        run: ./gradlew createConfigs componentTests
+        run: ./gradlew createConfigs componentTests --continue

.github/workflows/jdk21.yml

@@ -31,4 +31,4 @@ jobs:
       - name: Run Solr search service
         run: docker-compose run -d -p 8983:8983 solr
       - name: Run Backend Tests
-        run: ./gradlew createConfigs componentTests
+        run: ./gradlew createConfigs componentTests --continue

.github/workflows/pr.yml

@@ -13,31 +13,49 @@ jobs:
     permissions:
       pull-requests: write
     steps:
-    - uses: actions/github-script@v7
-      with:
-        script: |
-          const pr = await github.rest.pulls.get({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            pull_number: context.issue.number
-          })
-          const isTitleValid = /^\[#\d+\] /.test(pr.data.title)
-          const isDescriptionValid = /([Ff]ix(es|ed)?|[Cc]lose(s|d)?|[Rr]esolve(s|d)?|[Pp]art [Oo]f) #\d+/.test(pr.data.body)
-          if (isTitleValid && isDescriptionValid) {
-            return
-          }
-          let body = `Hi @${pr.data.user.login}, thank you for your interest in contributing to TEAMMATES!
-            However, your PR does not appear to follow our [contribution guidelines](https://teammates.github.io/teammates/process.html#step-4-submit-a-pr):\n\n`
-          if (!isTitleValid) {
-            body += "- Title must start with the issue number the PR is fixing in square brackets, e.g. `[#<issue-number>]`\n"
-          }
-          if (!isDescriptionValid) {
-            body += "- Description must reference the issue number the PR is fixing, e.g. `Fixes #<issue-number>` (or `Part of #<issue-number>` if the PR does not address the issue fully)\n"
-          }
-          body += "\nPlease address the above before we proceed to review your PR."
-          await github.rest.issues.createComment({
-            issue_number: context.issue.number,
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            body,
-          })
+      - uses: actions/github-script@v7
+        with:
+          script: |
+            const pr = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: context.issue.number
+            })
+            const isTitleValid = /^\[#\d+\] /.test(pr.data.title)
+            const isDescriptionValid = /([Ff]ix(es|ed)?|[Cc]lose(s|d)?|[Rr]esolve(s|d)?|[Pp]art [Oo]f) #\d+/.test(pr.data.body)
+            const descriptionRegex = /(?:[Ff]ix(?:es|ed)?|[Cc]lose(?:s|d)?|[Rr]esolve(?:s|d)?|[Pp]art [Oo]f) #(\d+)/
+            const extractIssueNumber = (description) => {
+              const match = description.match(descriptionRegex)
+              return match ? parseInt(match[1]) : null
+            };
+            const issueNumber = extractIssueNumber(pr.data.body)
+            let isIssueOpen = false
+            if (issueNumber) {
+              const issue = await github.rest.issues.get({
+                  owner: 'TEAMMATES',
+                  repo: 'teammates',
+                issue_number: issueNumber
+              })
+              isIssueOpen = issue.data.state === 'open'
+              if (isTitleValid && isDescriptionValid && isIssueOpen) {
+                return
+              }
+            }
+            let body = `Hi @${pr.data.user.login}, thank you for your interest in contributing to TEAMMATES!
+              However, your PR does not appear to follow our [contribution guidelines](https://teammates.github.io/teammates/process.html#step-4-submit-a-pr):\n\n`
+            if (!isTitleValid) {
+              body += "- Title must start with the issue number the PR is fixing in square brackets, e.g. `[#<issue-number>]`\n"
+            }
+            if (!isDescriptionValid) {
+              body += "- Description must reference the issue number the PR is fixing, e.g. `Fixes #<issue-number>` (or `Part of #<issue-number>` if the PR does not address the issue fully)\n"
+            }
+            if (!isIssueOpen && issueNumber) {
+              body += "- The issue referenced in the description (#" + issueNumber + ") is not open.\n"
+            }
+            body += "\nPlease address the above before we proceed to review your PR."
+            await github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body,
+            })

docs/development.md

@@ -326,7 +326,7 @@ Back-end component tests follow this configuration:
 
 Test suite | Command | Results can be viewed in
 ---|---|---
-`Component tests` | `./gradlew componentTests` | `{project folder}/build/reports/tests/componentTests/index.html`
+`Component tests` | `./gradlew componentTests --continue` | `{project folder}/build/reports/tests/componentTests/index.html`
 Any individual component test | `./gradlew componentTests --tests TestClassName` | `{project folder}/build/reports/tests/componentTests/index.html`
 
 You can generate the coverage data with `jacocoReport` task after running tests, e.g.:

docs/schema-migration.md

@@ -31,4 +31,5 @@ Here is a brief description of the activities defined for Liquibase
 5. Generate snapshot of database by running `./gradlew liquibaseSnapshot -PrunList=snapshot`, the snapshot will be output to `liquibase-snapshot.json`
 6. Checkout your branch and repeat steps 2 and 4 to generate the tables found on your branch
 7. Run `./gradlew liquibaseDiffChangeLog -PrunList=diffMain` to generate changeLog to resolve database schema differences
-
+8. Manually add a changeSet to tag the database using `release_number`. The tag should be named `<release_number` e.g `v9.0.0-beta.1` (See the last changeset in v9.0.0 for reference).
+9. Include the new changelog file as the last entry in `changelog-root.xml` as this is the order which changelogs are executed! (See [liquibase include tag](https://docs.liquibase.com/change-types/include.html))

package.json

@@ -39,7 +39,7 @@
     "firebase": "^10.7.2",
     "handsontable": "^14.1.0",
     "intersection-observer": "^0.12.2",
-    "moment-timezone": "^0.5.43",
+    "moment-timezone": "^0.5.45",
     "ng-dynamic-component": "^10.7.0",
     "ng-in-viewport": "^16.1.0",
     "ngx-captcha": "^13.0.0",

src/client/java/teammates/client/scripts/UpdateAccountRequestIndexing.java

@@ -0,0 +1,81 @@
+package teammates.client.scripts;
+
+import java.util.List;
+
+import jakarta.persistence.TypedQuery;
+import jakarta.persistence.criteria.CriteriaBuilder;
+import jakarta.persistence.criteria.CriteriaQuery;
+import jakarta.persistence.criteria.Root;
+
+import teammates.client.util.BackDoor;
+import teammates.client.util.ClientProperties;
+import teammates.common.datatransfer.SqlDataBundle;
+import teammates.common.exception.HttpRequestFailedException;
+import teammates.common.util.HibernateUtil;
+import teammates.storage.sqlentity.AccountRequest;
+
+/**
+ * Script to trigger indexing for all account requests.
+ */
+public class UpdateAccountRequestIndexing {
+    public static void main(String[] args) {
+        UpdateAccountRequestIndexing updater = new UpdateAccountRequestIndexing();
+        updater.initSession();
+        updater.updateAccountRequestIndexing();
+    }
+
+    /**
+     * Initializes the Hibernate session.
+     */
+    public void initSession() {
+        String connectionUrl = ClientProperties.SCRIPT_API_URL;
+        String username = ClientProperties.SCRIPT_API_NAME;
+        String password = ClientProperties.SCRIPT_API_PASSWORD;
+
+        HibernateUtil.buildSessionFactory(connectionUrl, username, password);
+    }
+
+    /**
+     * Updates the indexing for all account requests using the backdoor and batch processing.
+     */
+    public void updateAccountRequestIndexing() {
+        int batchSize = 100;
+        int firstResult = 0;
+        HibernateUtil.beginTransaction();
+        CriteriaBuilder cb = HibernateUtil.getCriteriaBuilder();
+        CriteriaQuery<AccountRequest> cr = cb.createQuery(AccountRequest.class);
+        Root<AccountRequest> root = cr.from(AccountRequest.class);
+        cr.select(root);
+        TypedQuery<AccountRequest> query = HibernateUtil.createQuery(cr)
+                .setMaxResults(batchSize);
+
+        List<AccountRequest> accountRequests;
+
+        do {
+            query.setFirstResult(firstResult);
+            accountRequests = query.getResultList();
+            SqlDataBundle dataBundle = new SqlDataBundle();
+
+            for (AccountRequest accountRequest : accountRequests) {
+                dataBundle.accountRequests.put(accountRequest.getId().toString(), accountRequest);
+            }
+
+            insertDocs(dataBundle);
+            firstResult += batchSize;
+        } while (!accountRequests.isEmpty());
+
+        HibernateUtil.commitTransaction();
+    }
+
+    /**
+     * Inserts the document.
+     */
+    public void insertDocs(SqlDataBundle dataBundle) {
+        try {
+            BackDoor.getInstance().putSqlDocuments(dataBundle);
+        } catch (HttpRequestFailedException e) {
+            System.out.println("Error occurred while inserting documents: " + e.getMessage());
+            e.printStackTrace();
+        }
+    }
+}

src/client/java/teammates/client/scripts/sql/IndexCourseFields.java

@@ -0,0 +1,37 @@
+package teammates.client.scripts.sql;
+
+import com.googlecode.objectify.cmd.Query;
+
+import teammates.client.scripts.DataMigrationEntitiesBaseScript;
+import teammates.storage.entity.Course;
+
+/**
+ * Index the newly-indexable fields of courses.
+ */
+public class IndexCourseFields extends DataMigrationEntitiesBaseScript<Course> {
+
+    public static void main(String[] args) {
+        new IndexCourseFields().doOperationRemotely();
+    }
+
+    @Override
+    protected Query<Course> getFilterQuery() {
+        return ofy().load().type(Course.class);
+    }
+
+    @Override
+    protected boolean isPreview() {
+        return true;
+    }
+
+    @Override
+    protected boolean isMigrationNeeded(Course course) {
+        return true;
+    }
+
+    @Override
+    protected void migrateEntity(Course course) {
+        // Save without any update; this will build the previously non-existing indexes
+        saveEntityDeferred(course);
+    }
+}