Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM-62207] VPC Endpint for ECR and s3 endpoint prefix list to outputs #290

Merged
merged 26 commits into from
Nov 21, 2024

Conversation

msingermann-domino
Copy link
Contributor

@msingermann-domino msingermann-domino commented Nov 7, 2024

Context:
Customers requested to restrict the outbound connection of the user workloads so they can only access the requested IPs
Added a list of allowed CIDRs to apply to the network policies that allows the egress for the services.
Separating the CIDRs in blocks (newrelic, cluster, s3, custom) allows us to configure different blocks to the services that needs them.
In order to get the right CIDRs for the cluster I added those CIDRs to the outputs
Also as we need to restrict image builder i aded an VPC Endpoint for ECR so we get the IPs for it to add to the allowlist.

@msingermann-domino msingermann-domino changed the title [DOM-62207] Add s3 endpoint prefix list (CIDRs) [DOM-62207] Add s3 endpoint prefix list to outputs Nov 7, 2024
@msingermann-domino msingermann-domino changed the title [DOM-62207] Add s3 endpoint prefix list to outputs [DOM-62207] VPC Endpint for ECR and s3 endpoint prefix list to outputs Nov 13, 2024
@msingermann-domino msingermann-domino marked this pull request as ready for review November 20, 2024 18:41
@msingermann-domino msingermann-domino requested a review from a team as a code owner November 20, 2024 18:41
examples/tfvars/ecr_endpoint.tfvars Outdated Show resolved Hide resolved
modules/infra/submodules/network/vpc.tf Show resolved Hide resolved
@msingermann-domino msingermann-domino enabled auto-merge (squash) November 21, 2024 19:29
@msingermann-domino msingermann-domino merged commit b344632 into main Nov 21, 2024
15 checks passed
@msingermann-domino msingermann-domino deleted the dom-62207 branch November 21, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants