-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOM-62207] VPC Endpint for ECR and s3 endpoint prefix list to outputs #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msingermann-domino
changed the title
[DOM-62207] Add s3 endpoint prefix list (CIDRs)
[DOM-62207] Add s3 endpoint prefix list to outputs
Nov 7, 2024
msingermann-domino
changed the title
[DOM-62207] Add s3 endpoint prefix list to outputs
[DOM-62207] VPC Endpint for ECR and s3 endpoint prefix list to outputs
Nov 13, 2024
Secretions
reviewed
Nov 20, 2024
Secretions
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Customers requested to restrict the outbound connection of the user workloads so they can only access the requested IPs
Added a list of allowed CIDRs to apply to the network policies that allows the egress for the services.
Separating the CIDRs in blocks (newrelic, cluster, s3, custom) allows us to configure different blocks to the services that needs them.
In order to get the right CIDRs for the cluster I added those CIDRs to the outputs
Also as we need to restrict image builder i aded an VPC Endpoint for ECR so we get the IPs for it to add to the allowlist.