Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miguelhar.mod migration #287

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Miguelhar.mod migration #287

merged 2 commits into from
Nov 6, 2024

Conversation

miguelhar
Copy link
Collaborator

  • Updates the example terraform configuration to integrate missing components like flyte.
  • Fixes provisioning the costs buckets part of the storage module even when costs is disabled

@miguelhar miguelhar requested a review from a team as a code owner November 1, 2024 22:19
Copy link
Contributor

@ddl-dclegg ddl-dclegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a couple of questions.

bin/module-migration/README.md Outdated Show resolved Hide resolved
examples/deploy/terraform/cluster/main.tf Show resolved Hide resolved
bin/module-migration/README.md Outdated Show resolved Hide resolved
bin/module-migration/README.md Outdated Show resolved Hide resolved
bin/module-migration/README.md Outdated Show resolved Hide resolved
@ddl-jacob
Copy link

looks good to me, :shipit:

bin/module-update/module-update.sh Outdated Show resolved Hide resolved
@miguelhar miguelhar force-pushed the miguelhar.mod-migration branch from edc5af9 to 06fe614 Compare November 6, 2024 17:17
@miguelhar miguelhar enabled auto-merge (squash) November 6, 2024 17:17
@miguelhar miguelhar merged commit 299ef4e into main Nov 6, 2024
15 checks passed
@miguelhar miguelhar deleted the miguelhar.mod-migration branch November 6, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants