-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miguelhar.mod migration #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
miguelhar
commented
Nov 1, 2024
- Updates the example terraform configuration to integrate missing components like flyte.
- Fixes provisioning the costs buckets part of the storage module even when costs is disabled
ddl-dclegg
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I have a couple of questions.
ddl-dclegg
approved these changes
Nov 4, 2024
ddl-jacob
reviewed
Nov 5, 2024
looks good to me, |
ddl-jacob
approved these changes
Nov 5, 2024
Secretions
reviewed
Nov 5, 2024
Secretions
approved these changes
Nov 5, 2024
miguelhar
force-pushed
the
miguelhar.mod-migration
branch
from
November 6, 2024 17:17
edc5af9
to
06fe614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.