[DOM-51856] - costs update lifecycle #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelhar
approved these changes
Nov 8, 2023
|
Validated with eks with long term storage jdbudget28539 and dev-v2 no long term storage jdbudget27853 |
miguelhar
approved these changes
Nov 14, 2023
| @@ -67,7 +67,7 @@ variable "storage" { | |||
| force_destroy_on_deletion = optional(bool) | |||
| })) | |||
| enable_remote_backup = optional(bool) | |||
| costs_enabled = optional(bool, true) | |||
| costs_enabled = optional(bool) | |||
There was a problem hiding this comment.
Why are we removing the default?
There was a problem hiding this comment.
moved the default to a higher level modules/infra/variables.tf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers who are not interested in extensive kubecost but using long-term storage will have a lot of cost data to the costs bucket anyway, while only the last 15 days of data will be actionable!
Add default lifecycle to limit long-term storage to 15 days.
Jira
https://dominodatalab.atlassian.net/browse/DOM-51856