Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-7428 PLAT-7427 CDK migration support #155

Merged
merged 4 commits into from
Oct 9, 2023
Merged

PLAT-7428 PLAT-7427 CDK migration support #155

merged 4 commits into from
Oct 9, 2023

Conversation

miguelhar
Copy link
Collaborator

@miguelhar miguelhar commented Oct 6, 2023 •
edited
Loading

PLAT-7427
PLAT-7428

  • Sometimes the hosted zone is private.
  • Wire in eks.service_ipv4_cidr

@miguelhar miguelhar marked this pull request as ready for review October 6, 2023 20:21
@miguelhar miguelhar requested a review from a team as a code owner October 6, 2023 20:21
@miguelhar miguelhar changed the title Add var for private hosted zone PLAT-7428 PLAT-7427 CDK migration support Oct 9, 2023
@miguelhar miguelhar merged commit d1a5b18 into main Oct 9, 2023
11 checks passed
@miguelhar miguelhar deleted the miguelhar.pvt-hosted-zone branch October 9, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddl-dclegg ddl-dclegg ddl-dclegg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelhar @ddl-dclegg