Fixes

dominodatalab · Nov 15, 2024 · 87b664e · 87b664e
1 parent 8cb7dad
commit 87b664e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/infra/submodules/network/README.md b/modules/infra/submodules/network/README.md
@@ -34,6 +34,7 @@ No modules.
 | [aws_route_table_association.pod](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route_table_association) | resource |
 | [aws_route_table_association.private](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route_table_association) | resource |
 | [aws_route_table_association.public](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route_table_association) | resource |
+| [aws_security_group.ecr-dkr-endpoint](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group) | resource |
 | [aws_subnet.pod](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/subnet) | resource |
 | [aws_subnet.private](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/subnet) | resource |
 | [aws_subnet.public](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/subnet) | resource |

diff --git a/modules/infra/submodules/network/vpc.tf b/modules/infra/submodules/network/vpc.tf
@@ -53,7 +53,7 @@ data "aws_prefix_list" "s3" {
   prefix_list_id = aws_vpc_endpoint.s3[0].prefix_list_id
 }
 
-resource "aws_security_group" "ecr-dkr-endpoint" {
+resource "aws_security_group" "ecr_dkr_endpoint" {
   name        = "${var.deploy_id}-ecr-dkr"
   description = "ECR Endpoint security group"
   vpc_id      = aws_vpc.this[0].id
@@ -63,7 +63,6 @@ resource "aws_security_group" "ecr-dkr-endpoint" {
     protocol    = "tcp"
     from_port   = 443
     to_port     = 443
-    type        = "ingress"
     self        = true
   }