-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
runc 1.0.0 containerd 1.5.2 buildkit is using master to pull in latest rootless bits tooling is now vendored as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested w/Domino too and LGTM. I'll let @sonnysideup have final say.
waiting on kustomize 4.2.0 binaries to appear... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fraenkel Check out my comments and see what you think. We can have a zoom chat if that's easier.
Re: moving main.go
to cmd/forge/main.go
, I'm a little curious what your thoughts are here. I was originally thinking that I would produce 2 separate binaries in my upcoming changes:
- controller
- builder
This project really houses two separate applications. Separate apps/CLIs with reused libraries feels like a cleaner design as opposed to the current, dual-mode based on command weirdness we have now. Assuming we go that direction, removing main.go
and setting the project up the way you've started makes sense to me. Was this the first step?
Would prefer separate binaries but it matters little given one image. Although they will be different sizes based on what is pulled in. The actual impetus was to get |
Minor changes to get things compiling again. Use embed instead of pkger Simplify the makefile Add a precommit target to verify no code generation is needed client-gen expects API_DIR/group/version directories. If there is only one level, it will treat it as a group with an internalversion, i.e., unspecified.
Upgrade to v4.2.0 Remove workarounds which are now unnecessary
Force rootless builds
Support token authorization for docker registry v2
Update dependencies