use elastic-charts axis calculation (elastic#130429)

src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx

@@ -530,6 +530,7 @@ describe('XYChart component', () => {
         fit: false,
         min: 123,
         max: 456,
+        includeDataFromIds: [],
       });
     });
 
@@ -553,6 +554,7 @@ describe('XYChart component', () => {
         fit: true,
         min: NaN,
         max: NaN,
+        includeDataFromIds: [],
       });
     });
 
@@ -582,6 +584,7 @@ describe('XYChart component', () => {
         fit: false,
         min: NaN,
         max: NaN,
+        includeDataFromIds: [],
       });
     });
 
@@ -613,6 +616,7 @@ describe('XYChart component', () => {
         fit: false,
         min: NaN,
         max: NaN,
+        includeDataFromIds: [],
       });
     });
 
@@ -622,44 +626,9 @@ describe('XYChart component', () => {
       const component = shallow(<XYChart {...defaultProps} data={data} args={args} />);
       expect(component.find(Axis).find('[id="left"]').prop('domain')).toEqual({
         fit: false,
-        min: 0,
-        max: 150,
-      });
-    });
-
-    test('it should ignore referenceLine values when set to custom extents', () => {
-      const { data, args } = sampleArgsWithReferenceLine();
-
-      const component = shallow(
-        <XYChart
-          {...defaultProps}
-          data={data}
-          args={{
-            ...args,
-            yLeftExtent: {
-              type: 'axisExtentConfig',
-              mode: 'custom',
-              lowerBound: 123,
-              upperBound: 456,
-            },
-          }}
-        />
-      );
-      expect(component.find(Axis).find('[id="left"]').prop('domain')).toEqual({
-        fit: false,
-        min: 123,
-        max: 456,
-      });
-    });
-
-    test('it should work for negative values in referenceLines', () => {
-      const { data, args } = sampleArgsWithReferenceLine(-150);
-
-      const component = shallow(<XYChart {...defaultProps} data={data} args={args} />);
-      expect(component.find(Axis).find('[id="left"]').prop('domain')).toEqual({
-        fit: false,
-        min: -150,
-        max: 5,
+        min: NaN,
+        max: NaN,
+        includeDataFromIds: ['referenceLine-referenceLine-a-rect'],
       });
     });
   });

src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx

@@ -57,7 +57,6 @@ import {
   getAxesConfiguration,
   GroupsConfiguration,
   validateExtent,
-  computeOverallDataDomain,
   getColorAssignments,
   getLinesCausedPaddings,
 } from '../helpers';
@@ -338,42 +337,21 @@ export function XYChart({
         min = extent.lowerBound ?? NaN;
         max = extent.upperBound ?? NaN;
       }
-    } else {
-      const axisHasReferenceLine = referenceLineLayers.some(({ yConfig }) =>
-        yConfig?.some(({ axisMode }) => axisMode === axis.groupId)
-      );
-      if (!fit && axisHasReferenceLine) {
-        // Remove this once the chart will support automatic annotation fit for other type of charts
-        const { min: computedMin, max: computedMax } = computeOverallDataDomain(
-          filteredLayers,
-          axis.series.map(({ accessor }) => accessor),
-          data.tables
-        );
-
-        if (computedMin != null && computedMax != null) {
-          max = Math.max(computedMax, max || 0);
-          min = Math.min(computedMin, min || 0);
-        }
-        for (const { layerId, yConfig } of referenceLineLayers) {
-          const table = data.tables[layerId];
-          for (const { axisMode, forAccessor } of yConfig || []) {
-            if (axis.groupId === axisMode) {
-              for (const row of table.rows) {
-                const value = row[forAccessor];
-                // keep the 0 in view
-                max = Math.max(value, max || 0, 0);
-                min = Math.min(value, min || 0, 0);
-              }
-            }
-          }
-        }
-      }
     }
 
     return {
       fit,
       min,
       max,
+      includeDataFromIds: referenceLineLayers
+        .flatMap((l) =>
+          l.yConfig ? l.yConfig.map((yConfig) => ({ layerId: l.layerId, yConfig })) : []
+        )
+        .filter(({ yConfig }) => yConfig.axisMode === axis.groupId)
+        .map(
+          ({ layerId, yConfig }) =>
+            `${layerId}-${yConfig.forAccessor}-${yConfig.fill !== 'none' ? 'rect' : 'line'}`
+        ),
     };
   };
 

src/plugins/chart_expressions/expression_xy/public/helpers/index.ts

@@ -12,7 +12,6 @@ export * from './state';
 export * from './visualization';
 export * from './fitting_functions';
 export * from './axes_configuration';
-export * from './reference_lines';
 export * from './icon';
 export * from './color_assignment';
 export * from './annotations_icon_set';