koekeishiya#230 properly handle destruction and re-creation of view u…

…pon layout change
dominiklohmann · Sep 6, 2019 · dbb1cbf · dbb1cbf
1 parent d42ab43
commit dbb1cbf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Workaround to make sure a window actually set the proper dimensions [#226](https://github.com/koekeishiya/yabai/issues/226) [#188](https://github.com/koekeishiya/yabai/issues/188)
 - Moving window to a different space using rules could leave an empty tile [#232](https://github.com/koekeishiya/yabai/issues/232)
 - Windows spawned while the owning application is hidden should not cause an empty tile to be created [#233](https://github.com/koekeishiya/yabai/issues/233)
+- Properly handle destruction and re-creation of view when layout changes between bsp and float [#230](https://github.com/koekeishiya/yabai/issues/230)
 
 ## [1.1.2] - 2019-07-15
 ### Changed

diff --git a/src/message.c b/src/message.c
@@ -605,6 +605,7 @@ static void handle_domain_config(FILE *rsp, struct token domain, char *message)
                     if (space_is_user(sel_sid)) {
                         view->layout = VIEW_FLOAT;
                         view->custom_layout = true;
+                        view_clear(view);
                     } else {
                         daemon_fail(rsp, "cannot set layout for a macOS fullscreen space!\n");
                     }

diff --git a/src/view.c b/src/view.c
@@ -551,5 +551,6 @@ void view_clear(struct view *view)
         if (view->root->left)  window_node_destroy(view->root->left);
         if (view->root->right) window_node_destroy(view->root->right);
         memset(view->root, 0, sizeof(struct window_node));
+        view_update(view);
     }
 }