Use LocalApplicationData path instead of the executable's path #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565
Don't merge yet.
Use LocalApplicationData path instead of the executable's path to store persistent user data.
@leMicin This is a working fix, the data will be stored in
%AppData%\Roaming\sidekickwhich is the same place where Electron seems to store webkit stuff (such as localStorage, sessionStorage, etc.). In theory it's actually a better location than using%AppData%\Local\Programs\sidekickthat serves as the installation path.Might want to decide if we want to add logic for debugging purposes and see how we handle the Test Project.