GHSL-2020-145: escape ^ character to prevent code injection attacks #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, opener does not escape the
^
character which can lead to code injection. For example:If
${user}
is the string^&calc
, then on Windows this code will open the (meaningless) urlhttps://github.com/%5E
in a browser and launchcalc.exe
.We discussed this privately with the maintainer, who says that this is not a vulnerability because opener's entire purpose is to execute arbitrary commands.