Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows issue with ampersand in the URLs #12

Merged
merged 1 commit into from
Mar 24, 2015

Conversation

jakub-g
Copy link
Contributor

@jakub-g jakub-g commented Mar 23, 2015

Fixed #9

Tested in node:

require('./opener')('http://example.org/?a=1&b=2&c=3')

and in the command line:

./opener.js "http://example.org/?a=1&b=2&c=3"

now it opens those URLs correctly. In the command line it's still needed to quote the URL, I think there's no way around it, since Windows is interpreting the ampersand before it passes it to the program, unless you quote the param.

@jakub-g
Copy link
Contributor Author

jakub-g commented Mar 23, 2015

BTW regarding multiple arguments, it does not seem to work in Windows (I didn't check on other platforms). Basically

start "" "http://example.org/1" "http://example.org/2"

this opens the first URL only.

@domenic domenic merged commit eec5065 into domenic:master Mar 24, 2015
@domenic
Copy link
Owner

domenic commented Mar 24, 2015

Released as 1.4.1, thanks!

@jakub-g jakub-g deleted the windows-ampersand branch March 24, 2015 12:23
@jakub-g
Copy link
Contributor Author

jakub-g commented Mar 24, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query params in http link on Windows
2 participants