Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL-2741 Add retry for AWP tests #216

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

batyakopelowitz
Copy link
Contributor

No description provided.

retryInterval := time.Second * 5

f := func() (*http.Response, error) {
return client.NewRequestDo("POST", path, queryParams, req, nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use NewRequestDoRetry func.
example:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@dolevh-d9 dolevh-d9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note the note

@yuval-avram yuval-avram enabled auto-merge (squash) August 7, 2024 15:00
Copy link
Contributor

@shayde78 shayde78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuval-avram yuval-avram merged commit a98e92d into master Aug 8, 2024
3 checks passed
@dolevh-d9 dolevh-d9 deleted the AL-2741-add-retry-for-awp-tests branch August 8, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants