Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-3826 - Add Support for IA Policy #160

Merged
merged 28 commits into from
Nov 20, 2022
Merged

CON-3826 - Add Support for IA Policy #160

merged 28 commits into from
Nov 20, 2022

Conversation

barnuri-cp
Copy link
Contributor

No description provided.

omartawfeeq
omartawfeeq reviewed Nov 3, 2022
View reviewed changes
@omartawfeeq
Copy link
Contributor

Great Job Bar, needs couple of important things to do :
1- Add Go tests for both the resource and data source : Example : https://github.com/dome9/terraform-provider-dome9/blob/master/dome9/data_source_dome9_admission_control_policy_test.go
2- As i know, you need to add all the provider sdk operations inside this project (dome9-sdk-go) : example : dome9/dome9-sdk-go#114
3- as i remember, needs to run (go mod tidy && go mod vendor) to update go.sum file

omartawfeeq
omartawfeeq reviewed Nov 13, 2022
View reviewed changes
omartawfeeq
omartawfeeq reviewed Nov 14, 2022
View reviewed changes
omartawfeeq
omartawfeeq approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@omartawfeeq omartawfeeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job Bar

@barnuri-cp
Copy link
Contributor Author

run locally with @omartawfeeq the unit tests and pass
now testing locally with terraform

@barnuri-cp
Copy link
Contributor Author

tested also with terraform locally on our prod env

image

@barnuri-cp barnuri-cp requested a review from ronyscp November 20, 2022 12:53
@barnuri-cp barnuri-cp changed the title Con 3826 ia terraform supp CON-3826 - Add Support for IA Policy Nov 20, 2022
@barnuri-cp barnuri-cp merged commit 283e936 into master Nov 20, 2022
@barnuri-cp barnuri-cp deleted the CON-3826-ia-terraform-supp branch November 20, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronyscp ronyscp ronyscp approved these changes

@omartawfeeq omartawfeeq omartawfeeq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnuri-cp @omartawfeeq @ronyscp