Add type file, Support nested files, / index routes, and trailing ? query strings
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, just wondering if this can get merged. Thanks! |
domadams
reviewed
Mar 10, 2019
|
Take another look. I also think my changes cover issue #3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globto retrieve all nested files within directory/, and that route has a compressedindex.html, serve it. Important: Doesn't serve if no compressed `index.html is found?query strings. Query strings are sometimes used for caching but previous code confused them when detecting mime type. I'm unsure if there is a use case where the query string should be preserved but it's captured and kept for now.package-lock.json$from example; results in no matches