Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mariadb table opts and tests #384

Merged
merged 2 commits into from
Nov 26, 2024
Merged

add mariadb table opts and tests #384

merged 2 commits into from
Nov 26, 2024

Conversation

jycor
Copy link

@jycor jycor commented Nov 26, 2024

This PR adds support for parsing the mariadb table options listed here:
https://mariadb.com/kb/en/create-table/#table-options

They are all no-ops (much like many of the MySQL table options)

related: dolthub/dolt#8592

@jycor jycor requested a review from zachmu as a code owner November 26, 2024 22:08
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor merged commit cd8f828 into main Nov 26, 2024
4 checks passed
@jycor jycor deleted the james/mariadb branch November 26, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants