Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax support to allow CREATE USER statements to quote the auth plugin #382

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

fulghum
Copy link

@fulghum fulghum commented Nov 26, 2024

MySQL allows the auth plugin name to be quoted or unquoted, but our parser previously only supported the unquoted mode for most forms of CREATE USER. This change adds support for the following forms:

  • CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin';
  • CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin' BY random password;
  • CREATE USER user@localhost IDENTIFIED WITH 'auth_plugin' BY 'password';

@fulghum fulghum requested a review from zachmu as a code owner November 26, 2024 00:24
Copy link

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 7d7ad4a into main Nov 26, 2024
4 checks passed
@fulghum fulghum deleted the fulghum/create_user_with_plugin branch November 26, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants