Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AuthServer to support multiple authentication methods #379

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

fulghum
Copy link

@fulghum fulghum commented Nov 20, 2024

In preparation of supporting caching_sha2_password authentication, this change applies the refactoring from vitessio#8503 to our fork of Vitess so that we can more easily support multiple authentication methods.

Related to: dolthub/dolt#8496

@fulghum fulghum force-pushed the fulghum/auth-server-refactor branch from 9444d7c to f93d290 Compare November 20, 2024 23:27
@fulghum fulghum marked this pull request as ready for review November 22, 2024 00:27
@fulghum fulghum requested a review from zachmu as a code owner November 22, 2024 00:27
Copy link

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Logic looks good

go/mysql/auth_server_test.go Show resolved Hide resolved
go/mysql/auth_server.go Show resolved Hide resolved
… net.Addr indicating the remote address of the connected client. This host information is needed in GMS to identify the correct user record.
@fulghum fulghum force-pushed the fulghum/auth-server-refactor branch from 3e7b5ff to 761846e Compare November 22, 2024 18:09
@fulghum fulghum merged commit a1ccb74 into main Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants