Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded Authorization #372

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Embedded Authorization #372

merged 2 commits into from
Nov 4, 2024

Conversation

Hydrocharged
Copy link

@Hydrocharged Hydrocharged commented Oct 22, 2024 •
edited
Loading

@Hydrocharged Hydrocharged requested a review from zachmu as a code owner October 22, 2024 16:10
zachmu
zachmu reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach is pretty viable, putting the auth information into the AST makes sense as an integration point between Dolt and Doltgres (and potentially future frontends).

Interested in hearing Max's thoughts.

@Hydrocharged Hydrocharged force-pushed the daylon/node-auth branch 2 times, most recently from ec9b64c to b08cb9f Compare October 30, 2024 16:57
@Hydrocharged Hydrocharged changed the title POC early authorization Embedded Authorization Oct 30, 2024
@Hydrocharged Hydrocharged mentioned this pull request Oct 30, 2024
Merged
zachmu
zachmu approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go/vt/sqlparser/ast_permissions.go Show resolved Hide resolved
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 0084bf0 into main Nov 4, 2024
4 checks passed
@Hydrocharged Hydrocharged deleted the daylon/node-auth branch November 4, 2024 11:07
@BrewTestBot BrewTestBot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu