Super Type Demonstration #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Vitess side of the super type demonstration implementation. This serves as a sort of "implementation guide" to see what kinds of changes a super type could potentially need. For Vitess, Doltgres will need a way to inject arbitrary expressions into the AST, since the Vitess AST is being used as an intermediate format. Currently, all nodes are for specific actions that aren't necessarily able to be generalized across SQL implementations (that is, anything that isn't MySQL). Doltgres needs to be able to add its own nodes without needing to add everything to Vitess, and Vitess should remain focused on MySQL syntax.
The best solution would require a new AST format that's generic to all SQL implementations (something like assembly being applicable to all programming languages), so this is sort of a "step 1" toward that goal.