Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow unquoted non reserved keywords for drop and rename column ddl #288

Merged
merged 1 commit into from
Nov 6, 2023
Merged

allow unquoted non reserved keywords for drop and rename column ddl #288

merged 1 commit into from
Nov 6, 2023

Conversation

jycor
Copy link

@jycor jycor commented Nov 6, 2023

@jycor jycor requested a review from zachmu as a code owner November 6, 2023 19:51
zachmu
zachmu approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit 51b7694 into main Nov 6, 2023
4 checks passed
@jycor jycor deleted the james/reserved branch November 6, 2023 19:59
This was referenced Nov 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot DROP column if it's named geometry
2 participants
@jycor @zachmu