Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the warning checks in enginetest to be more strict #2792

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

macneale4
Copy link
Contributor

Previously if an error was expected but none was produced the test would pass.

Previously if an error was expected but none was produced the test
would pass.
@macneale4 macneale4 requested review from zachmu and removed request for max-hoffman December 13, 2024 20:07
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macneale4 macneale4 merged commit acc1c41 into main Dec 13, 2024
8 checks passed
@macneale4 macneale4 deleted the macneale4/strict-warning-tests branch December 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants